Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow set default job image via env var #213

Open
piotrminkina opened this issue Nov 22, 2023 · 4 comments
Open

Feature: Allow set default job image via env var #213

piotrminkina opened this issue Nov 22, 2023 · 4 comments

Comments

@piotrminkina
Copy link
Contributor

Hello,

I would like to use Helm Controller in an enterprise environment without open internet access. All Docker images used on the Kubernetes cluster come from our internal image registry and there is no way to deploy images from other sources. Currently, you allow the job image to be set using the spec.jobImage field in the HelmController resource, but in my case this forces us to overwrite it in every deployed resource of this type.

DefaultJobImage = "rancher/klipper-helm:v0.8.2-build20230815"

Please allow me to change the default image for Job by setting an environment variable on the HelmController container. Thank you in advance for this possibility.

Regards
Piotr Minkina

@brandond
Copy link
Member

PR welcome!

@piotrminkina
Copy link
Contributor Author

@brandond done :)

@piotrminkina
Copy link
Contributor Author

@brandond The Docker image for version v0.15.5 has not yet been built. Shouldn't this happen automatically when the new version is released?

@brandond
Copy link
Member

brandond commented Jan 4, 2024

Yes, but there was some maintenance to our CI infra that appears to have removed the GH API token. I've opened an issue and will re-run CI when it is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants