Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Operator install to include kabanero-webhook #237

Closed
mchenggit opened this issue Oct 14, 2019 · 6 comments · Fixed by #271
Closed

Operator install to include kabanero-webhook #237

mchenggit opened this issue Oct 14, 2019 · 6 comments · Fixed by #271
Assignees

Comments

@mchenggit
Copy link

We are adding a new container kabanero-webhook, and it needs to be installed with kabanero operator.

@kaczyns
Copy link
Member

kaczyns commented Oct 14, 2019

@mchenggit do you need a service/route for your new container? If so, is it HTTP or HTTPS, and do you need it to have a specific path component (after the hostname)?

@mchenggit
Copy link
Author

It will be https.

If you can route to us without path component, then we don't need it. Otherwise, please add "/webhook". The external URL will be: https://:/webhook/

@kaczyns
Copy link
Member

kaczyns commented Oct 14, 2019

I've created a kabanero-operator image that supports what you sent. You'll need to try it out and let me know if it's close to what you need.

  1. Install kabanero-foundation, any version
  2. oc set image -n kabanero deployment/kabanero-operator kaczyns/kabanero-operator:webhook-phase0
  3. Edit your Kabanero CR instance to be version: 0.3.0 and Spec.Webhook.Enabled: true.

Example Kabanero CR instance:

apiVersion: kabanero.io/v1alpha1
kind: Kabanero
metadata:
  name: kabanero
  namespace: kabanero
spec:
  collections:
    repositories:
      - activateDefaultCollections: true
        name: incubator
        url: >-
          https://github.com/kabanero-io/collections/releases/download/v0.1.2/kabanero-index.yaml
  webhook:
    enable: true
  version: 0.3.0

Let me know when you've had a chance to try this. The branch where I've made these changes is here:
https://github.com/kaczyns/kabanero-operator/tree/webhook

@marikaj123
Copy link
Member

Is the work for this issue continue to be targeted for v0.3.0 release?

@hibell
Copy link
Member

hibell commented Oct 29, 2019

@kaczyns We have some proposed changes to the kabanero-webhook.yaml to be able to set up the TLS listener. It can be found here. Let me know if you need help with anything. :)

@kaczyns
Copy link
Member

kaczyns commented Oct 30, 2019

@marikaj123 Yes this is targeted for v0.3.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants