Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Make gh version check timeout configurable #477

Open
4 tasks done
eroji opened this issue Jul 11, 2024 · 4 comments · May be fixed by #518
Open
4 tasks done

BE: Make gh version check timeout configurable #477

eroji opened this issue Jul 11, 2024 · 4 comments · May be fixed by #518
Labels
good first issue Up for grabs scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature

Comments

@eroji
Copy link

eroji commented Jul 11, 2024

Issue submitter TODO list

  • I've looked up my issue in FAQ
  • I've searched for an already existing issues here
  • I've tried running main-labeled docker image and the issue still persists there
  • I'm running a supported version of the application which is listed here

Describe the bug (actual behavior)

I tried to run the lastest v1.0.0 kafbat-ui in both standalone Docker and in Kubernetes. When running standalone, the UI looks fine, but when running in Kubernetes as a deployment, the UI shows this.

image

Expected behavior

The application should be able to find what the latest version is and not indicate that it is outdated.

Your installation details

See my attached screenshot. The application is deployed as a deployment, with some modifications done to the Helm version, but none of which should prevent it from checking for the latest version.

apiVersion: apps/v1
kind: Deployment
metadata:
  name: kafka-ui
  labels:
    app.kubernetes.io/name: kafka-ui
    app.kubernetes.io/instance: kafka-ui
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: kafka-ui
      app.kubernetes.io/instance: kafka-ui
  template:
    metadata:
      labels:
        app.kubernetes.io/name: kafka-ui
        app.kubernetes.io/instance: kafka-ui
    spec:
      serviceAccountName: kafka-ui
      containers:
      - name: kafka-ui-pod
        image: ghcr.io/kafbat/kafka-ui:v1.0.0
        imagePullPolicy: IfNotPresent
        env:
        - name: AUTH_TYPE
          value: "LOGIN_FORM"
        - name: SPRING_SECURITY_USER_NAME
          value: "admin"
        - name: SPRING_SECURITY_USER_PASSWORD
          valueFrom:
            secretKeyRef:
              name: kafka-ui-secret
              key: password
        ports:
          - name: http
            containerPort: 8080
            protocol: TCP
        livenessProbe:
          httpGet:
            path: /actuator/health
            port: http
          initialDelaySeconds: 45
          periodSeconds: 30
          timeoutSeconds: 10
        readinessProbe:
          httpGet:
            path: /actuator/health
            port: http
          initialDelaySeconds: 45
          periodSeconds: 30
          timeoutSeconds: 10
        resources:
          limits:
            cpu: 500m
            memory: 500Mi
          requests:
            cpu: 250m
            memory: 200Mi
        volumeMounts:
        - name: config
          mountPath: /etc/kafkaui/config.yaml
          subPath: config.yaml
      volumes:
      - name: config
        configMap:
          name: kafka-ui-configmap

Steps to reproduce

Deploy the above manifest inside a Kubernetes cluster.

Screenshots

image

Logs

No response

Additional context

No response

@eroji eroji added status/triage Issues pending maintainers triage type/bug Something isn't working labels Jul 11, 2024
@kapybro kapybro bot added status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jul 11, 2024
Copy link

Hi eroji! 👋

Welcome, and thank you for opening your first issue in the repo!

Please wait for triaging by our maintainers.

As development is carried out in our spare time, you can support us by sponsoring our activities or even funding the development of specific issues.
Sponsorship link

If you plan to raise a PR for this issue, please take a look at our contributing guide.

@Haarolean
Copy link
Member

the default timeout for fetching version info is 10 secs, we might want to increase and/or add retries

@eroji
Copy link
Author

eroji commented Jul 15, 2024

@Haarolean this value is currently hardcoded?

@Haarolean
Copy link
Member

@eroji yeah it is

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes and removed type/bug Something isn't working status/triage/manual Manual triage in progress labels Jul 21, 2024
@Haarolean Haarolean changed the title Latest verion is showing "Your app version is outdated. Latest version is UNKNOWN" when run inside Kubernetes BE: Make gh version check timeout configurable Jul 21, 2024
@Haarolean Haarolean added the good first issue Up for grabs label Jul 21, 2024
@wernerdv wernerdv linked a pull request Jul 31, 2024 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Up for grabs scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants