Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UKI: Verify images signature before upgrade #2200

Closed
Tracked by #1792
mudler opened this issue Jan 31, 2024 · 1 comment · Fixed by kairos-io/kairos-agent#337
Closed
Tracked by #1792

UKI: Verify images signature before upgrade #2200

mudler opened this issue Jan 31, 2024 · 1 comment · Fixed by kairos-io/kairos-agent#337
Assignees
Labels
enhancement New feature or request uki

Comments

@mudler
Copy link
Member

mudler commented Jan 31, 2024

Is your feature request related to a problem? Please describe.

When we do an upgrade, it's a blind-action. That is to say that we pull the image nevertheless of the content and we lay the content inside the EFI directories

Describe the solution you'd like

Before laying the content down, would be preferred to check the integrity of the UKI files, so we know that we install something that at least doesn't break measurement and will get into a booting system afterwards (if there aren't errors on the image itself). This would save us from pulling EFI files signed by other entities or not-compatible keys.

Describe alternatives you've considered

Additional context

@mudler
Copy link
Member Author

mudler commented Apr 3, 2024

as @nianyush pointed out, maybe https://github.com/Foxboron/sbctl/blob/master/cmd/sbctl/verify.go#L62 sbctl verify <filename> could do the trick (still untested)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request uki
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants