Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device json schema to allow other device paths #2906

Open
Tracked by #2909
jimmykarily opened this issue Oct 1, 2024 · 10 comments
Open
Tracked by #2909

Fix device json schema to allow other device paths #2906

jimmykarily opened this issue Oct 1, 2024 · 10 comments
Labels
bug Something isn't working hacktoberfest

Comments

@jimmykarily
Copy link
Contributor

jimmykarily commented Oct 1, 2024

After this: kairos-io/kairos-agent#552
we should now update the schema to allow these new paths: https://github.com/kairos-io/kairos-sdk/blob/156caa6f8c9066b99417912a572285c33ab44b3c/schema/install_schema.go#L14

Auroraboot fails with this if we don't:

Target OSs /etc/systemd/system/cloud_init.yaml does not pass validation. Quitting.
jsonschema: '/install/device' does not validate with file:///schema.json#/properties/install/$ref/properties/device/pattern: does not match pattern '^(auto|/|(/[a-zA-Z0-9_-]+)+)$'
@jimmykarily jimmykarily added the bug Something isn't working label Oct 1, 2024
@HariniKrishnan
Copy link

Hi, can I work on this bug?

@jimmykarily
Copy link
Contributor Author

Hi, can I work on this bug?

By all means @HariniKrishnan! Give it a shot. If it takes too long we may have to pick it up within the core team to unblock people though.

@HariniKrishnan
Copy link

@jimmykarily When are we expecting the code, can I take a week's time?

@mudler
Copy link
Member

mudler commented Oct 1, 2024

@jimmykarily When are we expecting the code, can I take a week's time?

Sure thing @HariniKrishnan ! Thank you 💯

@mudler mudler mentioned this issue Oct 1, 2024
42 tasks
@mauromorales
Copy link
Member

@HariniKrishnan I'll assign you to the ticket, it's not to put any pressure but just to also see it on the dashboard that someone is on it. If you need help or more time, just let us know. Thanks!

@HariniKrishnan
Copy link

@mauromorales thanks a lot!

@HariniKrishnan
Copy link

whom should I reach out to for doubts reg this issue?

@mauromorales
Copy link
Member

@HariniKrishnan I'd say the slack channel is probably the best place because then whoever in the team looks at it and knows, can start helping. Just keep in mind for the replies that we are mostly in EU timeline

@HariniKrishnan
Copy link

HariniKrishnan commented Oct 8, 2024

[email protected] is my email!!! can you please add me to you workspace!

@jimmykarily
Copy link
Contributor Author

[email protected] is my email!!! can you please add me to you workspace!

You need to get a self-invitation here: https://slack.cncf.io/#kairos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
Status: Todo 🖊
Development

No branches or pull requests

5 participants