fix: 🐛 inverted conditionals on typescript transformer

sveltejs · Aug 29, 2019 · a6937f0 · a6937f0
1 parent 3d105ec
commit a6937f0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/transformers/postcss.js b/src/transformers/postcss.js
@@ -40,6 +40,7 @@ module.exports = async ({ content, filename, options, map = undefined }) => {
     options = await postcssLoadConfig(options, options.configFilePath)
   } catch (e) {
     /** Something went wrong, do nothing */
+    // istanbul ignore next
     if (e.code === 'MODULE_NOT_FOUND') {
       console.error(
         `[svelte-preprocess] PostCSS configuration was not passed. If you expect to load it from a file, make sure to install "postcss-load-config" and try again ʕ•ᴥ•ʔ`,

diff --git a/src/transformers/typescript.js b/src/transformers/typescript.js
@@ -35,18 +35,18 @@ function isSvelteFile(filename) {
 const IMPORTEE_PATTERN = /['"](.*?)['"]/
 function isValidSvelteImportDiagnostic(filename, diagnostic) {
   // TS2307: 'cannot find module'
-  if (diagnostic.code !== 2307) return false
+  if (diagnostic.code !== 2307) return true
 
   const importeeMatch = diagnostic.messageText.match(IMPORTEE_PATTERN)
   // istanbul ignore if
-  if (!importeeMatch) return false
+  if (!importeeMatch) return true
 
   let [, importeePath] = importeeMatch
   /** if we're not dealing with a relative path, assume the file exists */
-  if (importeePath[0] !== '.') return true
+  if (importeePath[0] !== '.') return false
 
   /** if the importee is not a svelte file, do nothing */
-  if (!isSvelteFile(importeePath)) return false
+  if (!isSvelteFile(importeePath)) return true
 
   importeePath = resolve(dirname(filename), importeePath)