Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for compute_weighted_sum() #1000

Open
samarth9008 opened this issue May 23, 2024 · 3 comments
Open

Add unit tests for compute_weighted_sum() #1000

samarth9008 opened this issue May 23, 2024 · 3 comments
Assignees

Comments

@samarth9008
Copy link
Collaborator

samarth9008 commented May 23, 2024

We want to add unit tests for compute_weighted_sum()

Function location -

def compute_weighted_sum(

Guides for the test:

  • Create multiple small and simple dfs that will be easy to observe and compare (e.g. 2x2 squares with single value in every cell etc.)
  • Make a separate test for each index_mode
  • Compare outcomes with string signature approach iow you get the output, convert it to string and then check it right inside the test. For ref see tests in amp/helpers/test/test_hpandas.py e.g. Test_merge_dfs1

See unit test doc to follow the code style
Also highly recommend to read this doc before submitting 1st PR

FYI @gpsaggese @sonaalKant @DanilYachmenev

@samarth9008 samarth9008 self-assigned this May 23, 2024
@samarth9008
Copy link
Collaborator Author

@DanilYachmenev If possible can you refine the specs even more? Thank you!

@surbhi498
Copy link
Contributor

I have added the Unit Test Cases for function compute_weighted_sum in test_hpandas.py
The PR link enclosed:
#1041 (comment)

@dremdem
Copy link
Collaborator

dremdem commented Jun 11, 2024

@surbhi498 Can you add an epic please.
FYI @samarth9008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants