-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On-board Aarya Patel #381
Comments
Just a question for quick start for developing, but is the project not able to be supported via WSL2 and WSL2-backed docker system in Windows? |
Sorry, we only support Linux and Mac. For Windows we recommend installing Ubuntu in a VM. Running on Windows creates subtle bugs that are difficult to debug and not worth it. |
Are you able to solve the docker problem? |
Solved it for the most part with just installing VMWare and going the usual route but will let you know if I find a way to run a WSL-backed version of the container. Had some trouble trying to set things up as the terminal kept cache-locking due to unattended processes of security updates but fixed that and moving forward. |
@aaryapatel100 do we need to improve our documentation of how to set up the Ubuntu set-up for windows users based on your experience? |
I think for the most part it's pretty good at pointing in the right direction, although clarification on some edge-cases of setting up (within the VM) could help new contributors getting set up faster. However, for the most part combination of directions and error searching is solid. Quick question - for docker desktop, I should install within the VM and not on my actual computer correct? |
It is mentioned in https://github.com/sorrentum/sorrentum/blob/master/docs/Quick_start_for_developing.md |
Can you pls improve the doc, summarizing what you had to do and add links to what to download and how to install?
Correct. It needs to be installed inside the VM. Pls also document the process here. You can take screenshots, etc. We want to make sure everyone installs things in the same way. |
I've built the thin environment and currently trying to start the jupyter server, but it keeps erroring out to 'srfs' is not defined. This is even after I ran the pip install s3fs command while within the virtual environment. Any suggestions on how to fix this? |
Post the error logs as mentioned over here. https://github.com/sorrentum/sorrentum/blob/master/docs/First_review_process.md#do-not-use-screenshots |
|
How does the output look like while activating thin environment? |
|
Can you format the |
You can trying pulling a new images required for this. |
Here's the formatted output:
|
I would suggest installing new images because this is something which is not inside your docker container if I am not wrong. |
Quick update, but the issue stemmed from a build error that I fixed with an additional package added to the requirements.txt (details are within my documentation notes). But for the last step of quick_start_for_developing, am I supposed to run i docker_jupyter within the app? Tried: Output for
|
No within the local environment. |
Ok, finished the quick developing task. Here are all the steps that I added for setting up the VM (wasn't sure if you wanted me to directly update documentation):
follow steps on https://phoenixnap.com/kb/docker-permission-denied. After running Follow documentation steps for starting jupyter server and ensure everything works. |
Also, I managed to through all the quick-developing steps using the WSL2-backed setup as well on Windows. Was just wondering if the bugs with running this project on Windows were later down the line or should be good to work if the quick developing functions? |
|
If you are done with everything mark as done and feel free to close this issue. |
Ok, marked everything besides the warm-up issue which I haven't been assigned yet. |
Assigned. |
Closing as completed. |
Please follow this checklist. Post any errors you face in this issue.
FYI @gpsaggese @DanilYachmenev
The text was updated successfully, but these errors were encountered: