Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update - added email attribute and example command #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

versedi
Copy link
Contributor

@versedi versedi commented Oct 28, 2015

I've forgot to update readme when creating last commit and pull request.

Readme updated with --email="1" and example command in use.

@kalenjordan
Copy link
Owner

You know what actually can we change the command line option from --email to --send-email? Having email as a parameter feels like it is going to force a value for the customer email in the order that's created.

@versedi
Copy link
Contributor Author

versedi commented Nov 3, 2015

I was giving it a thought but decided to keep it short - it's indeed not so obvious so I think it'd be better.

@kalenjordan
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants