Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for ember-bootstrap v4 #43

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Drop support for ember-bootstrap v4 #43

merged 1 commit into from
Apr 28, 2022

Conversation

simonihmig
Copy link
Contributor

@simonihmig simonihmig added the breaking Breaking change label Apr 22, 2022
@simonihmig simonihmig requested a review from jelhan April 22, 2022 15:58
jelhan
jelhan approved these changes Apr 22, 2022
View reviewed changes
Copy link
Collaborator

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to reduce potential maintenance work required. Not supporting both Ember Bootstrap versions will help in that regard.

@simonihmig simonihmig merged commit cadd2cc into master Apr 28, 2022
@simonihmig simonihmig deleted the upd-eb branch April 29, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelhan jelhan jelhan approved these changes

Assignees
No one assigned
Labels
breaking Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonihmig @jelhan