Add back @placeholder argument
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #99 |
simonihmig
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
The change is fine.
CI is failing, for obviously unrelated issues:
- canary is failing for all addons, reported this today: [Bug] Canary fails build with "unable to locate global object" emberjs/ember.js#19431
- with floating deps there is some problem mit ember-bootstrap and @embroider/macros, will need to investigate
|
Released as 3.0.1! CI issue is this: embroider-build/embroider#701 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are instances of
@placeholderapplied to<form.element>(e. g. here and here) but I think they are erroneous. The dummy app is not rendering any placeholders.