Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Ember Power Select to v5 #307

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Conversation

jelhan
Copy link
Collaborator

@jelhan jelhan commented Apr 4, 2022

Adds explicit support for Ember Power Select v5 without dropping support for v4.

  • Upgrades ember-power-select to ^5.0.0.
  • Adds Ember Try scenario to run latest 4.x version of ember-power-select

@jelhan
Copy link
Collaborator Author

jelhan commented Apr 4, 2022

This breaks the build for the ember-bootstrap-v4 scenario: https://github.com/kaliber5/ember-bootstrap-power-select/runs/5812680874?check_suite_focus=true

I'm seeing the following error in CI:

broccoliBuilderErrorStack: Error: @babel/template placeholder "LOG_VIEW_LOOKUPS": Expected string substitution
    at applyReplacement (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/@babel/template/lib/populate.js:74:13)
    at /home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/@babel/template/lib/populate.js:44:7
    at Array.forEach (<anonymous>)
    at populatePlaceholders (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/@babel/template/lib/populate.js:42:43)
    at /home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/@babel/template/lib/string.js:20:51
    at /home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/@babel/template/lib/builder.js:75:14
    at Object.buildLiterals (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/ember-bootstrap/node_modules/@embroider/macros/src/babel/evaluate-json.js:377:73)
    at Object.inlineRuntimeConfig (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/ember-bootstrap/node_modules/@embroider/macros/src/babel/get-config.js:107:55)
    at PluginPass.enter (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/ember-bootstrap/node_modules/@embroider/macros/src/babel/macros-babel-plugin.js:77:38)
    at newFn (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/@babel/traverse/lib/visitors.js:177:21)
    =============
    at Object.buildLiterals (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/ember-bootstrap/node_modules/@embroider/macros/src/babel/evaluate-json.js:377:34)
    at Object.inlineRuntimeConfig (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/ember-bootstrap/node_modules/@embroider/macros/src/babel/get-config.js:107:55)
    at PluginPass.enter (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/ember-bootstrap/node_modules/@embroider/macros/src/babel/macros-babel-plugin.js:77:38)
    at newFn (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/@babel/traverse/lib/visitors.js:177:21)
    at NodePath._call (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/@babel/traverse/lib/path/context.js:53:20)
    at NodePath.call (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/@babel/traverse/lib/path/context.js:40:17)
    at NodePath.visit (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/@babel/traverse/lib/path/context.js:100:31)
    at TraversalContext.visitQueue (/home/runner/work/ember-bootstrap-power-select/ember-bootstrap-power-select/node_modules/@babel/traverse/lib/context.js:103:16)

Need to investigate before merging.

@simonihmig
Copy link
Contributor

@jelhan google search revealed this one: embroider-build/embroider#1077

@jelhan jelhan force-pushed the upgrade-ember-power-select-to-v5 branch from e816d0d to 9010a3b Compare April 6, 2022 11:26
@jelhan jelhan merged commit 9cb407c into master Apr 6, 2022
@jelhan jelhan deleted the upgrade-ember-power-select-to-v5 branch April 6, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants