Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder argument for power-select-multiple control #313

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Placeholder argument for power-select-multiple control #313

merged 1 commit into from
Jul 19, 2022

Conversation

NLaza
Copy link

@NLaza NLaza commented Jul 19, 2022

Passing the placeholder argument from the power-select-multiple control to the ember power select.

@jelhan jelhan added the bug label Jul 19, 2022
jelhan
jelhan approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Same fix was applied for <PowerSelect> component in #209 some time ago.

@jelhan jelhan merged commit bf9a195 into ember-bootstrap:master Jul 19, 2022
@jelhan
Copy link
Collaborator

jelhan commented Jul 19, 2022

Released as v4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelhan jelhan jelhan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NLaza @jelhan