Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disabling UI #107

Merged
merged 5 commits into from
Apr 16, 2018
Merged

feat: disabling UI #107

merged 5 commits into from
Apr 16, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Apr 1, 2018

Description of the Changes

Created a UI wrapper using the proxy pattern, which all the UI actions will pass through it.
UI can be disable using the following configuration:

ui: {
  disable: true
}

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Apr 1, 2018
@dan-ziv dan-ziv requested review from OrenMe and yairans April 1, 2018 20:07
@kaltura-hooks
Copy link

Hi @dan-ziv,
Thank you for contributing this pull request!
Please sign the Kaltura CLA so we can review and merge your contribution.
Learn more at http://bit.ly/KalturaContrib

@dan-ziv dan-ziv changed the title feat: suggested implementation for disabling UI feat: disabling UI Apr 11, 2018
@dan-ziv
Copy link
Contributor Author

dan-ziv commented Apr 16, 2018

build failing is not related to this change, merging

@dan-ziv dan-ziv merged commit 5784a75 into master Apr 16, 2018
@dan-ziv dan-ziv deleted the disableUi branch April 16, 2018 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants