Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-12610): Image Playback Engine - Support for rendering an image, with or without duration #598

Merged
merged 21 commits into from
Jan 22, 2023

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Jan 3, 2023

Description of the Changes

  • Auto configure the stream priority to image engine if an image source is detected
  • New isUntimedImage() public API (to which the playkit-js-ui is listening and sets the ui preset accordingly)
  • Add default duration of 5 sc for timed image items on Playlist

solves FEC-12610

related prs:
kaltura/playkit-js-image-player#1
kaltura/playkit-js#697
kaltura/playkit-js-providers#190
kaltura/playkit-js-ui#718

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

src/common/utils/setup-helpers.js Show resolved Hide resolved
src/kaltura-player.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
JonathanTGold added a commit to kaltura/playkit-js-ui that referenced this pull request Jan 19, 2023
JonathanTGold added a commit to kaltura/playkit-js-image-player that referenced this pull request Jan 19, 2023
@JonathanTGold JonathanTGold merged commit af31665 into master Jan 22, 2023
borhandarabi pushed a commit to TasvirChi/playchi-js-providers that referenced this pull request May 14, 2024
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants