fix(FEC-12479): [Dash] - Subtitles are too small and not centered #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladna
reviewed
Aug 15, 2022
5 tasks
SivanA-Kaltura
requested changes
Aug 21, 2022
SivanA-Kaltura
approved these changes
Aug 22, 2022
JonathanTGold
added a commit
to kaltura/playkit-js
that referenced
this pull request
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
issue: the player uses the shaka UITextDisplayer plugin to render text tracks with our container but does not load all relevant CSS class
fix: update the CSS file and replace the container
solves: FEC-12479
related pr: kaltura/playkit-js#660
CheckLists