Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12776): Dash Adapter does not support Default track from stream #219

Merged
merged 2 commits into from
Dec 21, 2022
Merged

fix(FEC-12776): Dash Adapter does not support Default track from stream #219

merged 2 commits into from
Dec 21, 2022

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Dec 1, 2022 •
edited
Loading

Description of the Changes

See here JSDoc: Class: shaka.extern
the Track.primary filed in dash parsed track (return form shaka.getTextTracks() API) indicates the default track
Which ignored by the adapter
(Unlike Hls Adapter which handles default track which indicated by Track.default field there)

solves FEC-12776

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@giladna giladna changed the title Dash Adapter does not support Default track from stream fix(FEC-12776): Dash Adapter does not support Default track from stream Dec 3, 2022
@JonathanTGold JonathanTGold mentioned this pull request Dec 13, 2022
Merged
5 tasks
JonathanTGold added a commit to kaltura/playkit-js that referenced this pull request Dec 21, 2022
@JonathanTGold
fix(FEC-12760): Blank Transcript Box In V7 Player (#682)
a9400ab 
solves FEC-12760

related pr:
kaltura/playkit-js-hls#183
kaltura/playkit-js-dash#219
@JonathanTGold JonathanTGold merged commit aa167de into master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tzipi-kaltura Tzipi-kaltura Tzipi-kaltura approved these changes

@giladna giladna Awaiting requested review from giladna

@SivanA-Kaltura SivanA-Kaltura Awaiting requested review from SivanA-Kaltura

@ErezKaltura ErezKaltura Awaiting requested review from ErezKaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanTGold @Tzipi-kaltura