Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default-config json container #39

Merged
merged 3 commits into from
Dec 10, 2017
Merged

feat: add default-config json container #39

merged 3 commits into from
Dec 10, 2017

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Dec 7, 2017

Description of the Changes

Add default-config.json for component.
Initial config - ignore VTT http bad response and parse issues - closes FEC-7593.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Dec 7, 2017
@OrenMe OrenMe changed the title fix(FEC-7593): Shaka throws an error when text cues requests fails feat: Shaka throws an error when text cues requests fails Dec 7, 2017
@OrenMe OrenMe changed the title feat: Shaka throws an error when text cues requests fails feat: add default-config json container Dec 7, 2017
OrenMe
OrenMe previously approved these changes Dec 7, 2017
@OrenMe
Copy link
Contributor

OrenMe commented Dec 7, 2017

Maybe better to add this to base class, but the import from json file can only be done in the component

@OrenMe OrenMe merged commit ad7a6dc into master Dec 10, 2017
@OrenMe OrenMe deleted the FEC-7593 branch December 10, 2017 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants