From c0fd7442f6b85b7897c499a58e2af1a145476e45 Mon Sep 17 00:00:00 2001 From: odedhutzler Date: Thu, 7 Dec 2017 15:20:03 +0200 Subject: [PATCH 1/3] adding ignore text cues issues configuration (only https bad response and parse issues) --- src/dash-adapter.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/dash-adapter.js b/src/dash-adapter.js index 91f4cb8e..44e42f51 100644 --- a/src/dash-adapter.js +++ b/src/dash-adapter.js @@ -104,6 +104,7 @@ export default class DashAdapter extends BaseMediaSourceAdapter { if (Utils.Object.hasPropertyPath(config, 'playback.options.html5.dash')) { dashConfig = config.playback.options.html5.dash; } + dashConfig['streaming'] = {ignoreTextStreamFailures: true}; return new this(videoElement, source, dashConfig); } From b7ad9254e6d68907f2719dd2edd9b8bdfdf28ce3 Mon Sep 17 00:00:00 2001 From: Oren Me Date: Thu, 7 Dec 2017 17:08:50 +0200 Subject: [PATCH 2/3] move config to default-config.json --- src/dash-adapter.js | 3 ++- src/default-config.json | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 src/default-config.json diff --git a/src/dash-adapter.js b/src/dash-adapter.js index 44e42f51..71b13f96 100644 --- a/src/dash-adapter.js +++ b/src/dash-adapter.js @@ -6,6 +6,7 @@ import {Utils} from 'playkit-js' import {Error} from 'playkit-js' import Widevine from './drm/widevine' import PlayReady from './drm/playready' +import {defaultConfig} from "./default-config" /** * Adapter of shaka lib for dash content @@ -104,7 +105,6 @@ export default class DashAdapter extends BaseMediaSourceAdapter { if (Utils.Object.hasPropertyPath(config, 'playback.options.html5.dash')) { dashConfig = config.playback.options.html5.dash; } - dashConfig['streaming'] = {ignoreTextStreamFailures: true}; return new this(videoElement, source, dashConfig); } @@ -175,6 +175,7 @@ export default class DashAdapter extends BaseMediaSourceAdapter { constructor(videoElement: HTMLVideoElement, source: Object, config: Object = {}) { DashAdapter._logger.debug('Creating adapter. Shaka version: ' + shaka.Player.version); super(videoElement, source, config); + this._config = Utils.Object.mergeDeep({}, this._config, defaultConfig); } /** diff --git a/src/default-config.json b/src/default-config.json new file mode 100644 index 00000000..87d336eb --- /dev/null +++ b/src/default-config.json @@ -0,0 +1,5 @@ +{ + "streaming": { + "ignoreTextStreamFailures": true + } +} From 7873490fde406da5230b91d1ddbcd58ec9a6ac79 Mon Sep 17 00:00:00 2001 From: odedhutzler Date: Sun, 10 Dec 2017 14:35:47 +0200 Subject: [PATCH 3/3] fixed quotes --- src/dash-adapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dash-adapter.js b/src/dash-adapter.js index 71b13f96..6557e27e 100644 --- a/src/dash-adapter.js +++ b/src/dash-adapter.js @@ -6,7 +6,7 @@ import {Utils} from 'playkit-js' import {Error} from 'playkit-js' import Widevine from './drm/widevine' import PlayReady from './drm/playready' -import {defaultConfig} from "./default-config" +import {defaultConfig} from './default-config' /** * Adapter of shaka lib for dash content