fix(FEC-7896): endless spinner appears right after changing audio track in IE and Edge #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trigger a playing event whenever an audio track is changed & time_update event is fired. This align Edge and IE behaviour to other browsers. When an audio track changed in IE & Edge, they trigger waiting event but not playing event
itaykinnrot
reviewed
Feb 11, 2018
src/hls-adapter.js
Outdated
| this._videoElement.dispatchEvent(new Event(BaseMediaSourceAdapter.Html5Events.PLAYING)); | ||
| this._videoElement.removeEventListener(BaseMediaSourceAdapter.Html5Events.TIME_UPDATE, timeUpdateListener); | ||
| } | ||
| this._videoElement.addEventListener(BaseMediaSourceAdapter.Html5Events.TIME_UPDATE, timeUpdateListener) |
There was a problem hiding this comment.
@odedhutzler we dont have once? (listen only once to the event?)
all in all looks good!
itaykinnrot
previously approved these changes
Feb 11, 2018
|
@odedhutzler please dispatch the event from the adapter itself and not from the video element and change the PR title to the ticket title and make the current title as the description |
odedhutzler
changed the title
dan-ziv
approved these changes
Feb 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Handling a situation after audio track is changed, only in IE and Edge.
If a waiting event is sent, we send playing event.
@dan-ziv, I didn't use the event manager i thought it's an overkill, cause it's not imported anyway.. let me know if you think otherwise.
CheckLists