fix: re-design companions config #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-ziv
changed the title
yairans
suggested changes
Dec 5, 2017
src/ima.js
Outdated
| selectionCriteria.resourceType = this._sdk.CompanionAdSelectionSettings.ResourceType.ALL; | ||
| selectionCriteria.creativeType = this._sdk.CompanionAdSelectionSettings.CreativeType.ALL; | ||
| const sizeCriteria = this.config.companions.sizeCriteria; | ||
| switch (sizeCriteria) { |
There was a problem hiding this comment.
unnecessary switch-case. just pass the sizeCriteria as is.
selectionCriteria.sizeCriteria = this._sdk.CompanionAdSelectionSettings.SizeCriteria[sizeCriteria] || this._sdk.CompanionAdSelectionSettings.SizeCriteria.SELECT_EXACT_MATCH
dan-ziv
changed the title
dan-ziv
changed the title
|
@yairans fixed according to your comment, please review |
yairans
approved these changes
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Previous structure:
companions: { testCompanionSquare: { width: 300, height: 250, sizeCriteria: 'SELECT_EXACT_MATCH' } }New structure:
companions: { ads: { testCompanionSquare: { width: 300, height: 250, } }, sizeCriteria: 'SELECT_EXACT_MATCH' }CheckLists