fix(FEC-8097): adsRenderingSettings aren’t applied #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-ziv
suggested changes
Apr 8, 2018
| @@ -454,7 +454,7 @@ export default class Ima extends BasePlugin { | |||
| this._sdk.settings.setPlayerVersion(this.config.playerVersion); | |||
| this._sdk.settings.setVpaidAllowed(true); | |||
| this._sdk.settings.setVpaidMode(this._sdk.ImaSdkSettings.VpaidMode.ENABLED); | |||
| if (this.config.setDisableCustomPlaybackForIOS10Plus === 'boolean') { | |||
| if (typeof this.config.setDisableCustomPlaybackForIOS10Plus === 'boolean') { | |||
There was a problem hiding this comment.
@odedhutzler
Although this is a good fix, how this is related to the adsRenderingSettings?
There was a problem hiding this comment.
U r right @dan-ziv, added a fix for undefined instead of null on IMA adsRenderingSettings.
Please update your request for changes
There was a problem hiding this comment.
@odedhutzler I think we can add tests for this - please check
dan-ziv
previously approved these changes
Apr 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Fix conditional check for IMA AdsRenderingSettings object.
CheckLists