Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8107): ad video fails to play and only ad audio plays in full screen mode #51

Merged
merged 2 commits into from
Apr 9, 2018
Merged

fix(FEC-8107): ad video fails to play and only ad audio plays in full screen mode #51

merged 2 commits into from
Apr 9, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Apr 8, 2018 •
edited
Loading

Description of the Changes

When playing with different video tags on iOS ads are not
supported in native full screen, so need to exist full screen before ads started.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Apr 8, 2018
@dan-ziv dan-ziv changed the title fix(VIACMAINT-69): iPad - Ad video fails to play and only Ad audio plays in full screen mode fix(VIACMAINT-69): ad video fails to play and only ad audio plays in full screen mode Apr 8, 2018
OrenMe
OrenMe previously requested changes Apr 8, 2018
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-ziv please handle ticket name as FEC

@dan-ziv dan-ziv changed the title fix(VIACMAINT-69): ad video fails to play and only ad audio plays in full screen mode fix(FEC-8107): ad video fails to play and only ad audio plays in full screen mode Apr 9, 2018
@dan-ziv dan-ziv merged commit 0b2f455 into master Apr 9, 2018
@dan-ziv dan-ziv deleted the VIACMAINT-69 branch April 9, 2018 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe left review comments

@yairans yairans Awaiting requested review from yairans

@odedhutzler odedhutzler Awaiting requested review from odedhutzler

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe