fix(FEC-7207): fix buffering stats (#15)

kaltura · Sep 27, 2017 · ab934f5 · ab934f5
1 parent 606b21f
commit ab934f5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/kanalytics.js b/src/kanalytics.js
@@ -117,10 +117,10 @@ export default class KAnalytics extends BasePlugin {
    * @return {void}
    */
   _onPlayerStateChanged(event: any): void {
-    if (event.payload.newState === this.player.State.BUFFERING) {
+    if (event.payload.newState.type === this.player.State.BUFFERING) {
       this._sendAnalytics(EventTypes.BUFFER_START);
     }
-    if (event.payload.oldState === this.player.State.BUFFERING) {
+    if (event.payload.oldState.type === this.player.State.BUFFERING) {
       this._sendAnalytics(EventTypes.BUFFER_END);
     }
   }

diff --git a/test/src/kanalytics.spec.js b/test/src/kanalytics.spec.js
@@ -144,7 +144,12 @@ describe('KAnalyticsPlugin', function () {
 
   it('should send buffer start', () => {
     player.dispatchEvent({type: player.Event.PLAYER_STATE_CHANGED, payload:{
-      'newState': player.State.BUFFERING
+      'newState': {
+        'type': player.State.BUFFERING
+      },
+      'oldState': {
+        'type': player.State.PLAYING
+      }
     }});
     let payload = sendSpy.lastCall.args[0];
     verifyPayloadProperties(payload.ks, payload.event);
@@ -154,7 +159,12 @@ describe('KAnalyticsPlugin', function () {
 
   it('should send buffer end', () => {
     player.dispatchEvent({type: player.Event.PLAYER_STATE_CHANGED, payload:{
-      'oldState': player.State.BUFFERING
+      'newState': {
+        'type': player.State.PLAYING
+      },
+      'oldState': {
+        'type': player.State.BUFFERING
+      }
     }});
     let payload = sendSpy.lastCall.args[0];
     verifyPayloadProperties(payload.ks, payload.event);