fix(FEC-8029): play reached 100% event sent before ended (#30)

sending play reached 100% event only when currentTime equals the duration
kaltura · Apr 16, 2018 · bb062b9 · bb062b9
1 parent df9b884
commit bb062b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/kanalytics.js b/src/kanalytics.js
@@ -191,7 +191,7 @@ export default class KAnalytics extends BasePlugin {
         this._timePercentEvent.PLAY_REACHED_75 = true;
         this._sendAnalytics(EventTypes.PLAY_REACHED_75);
       }
-      if (!this._timePercentEvent.PLAY_REACHED_100 && percent >= .98) {
+      if (!this._timePercentEvent.PLAY_REACHED_100 && percent >= 1) {
         this._timePercentEvent.PLAY_REACHED_100 = true;
         this._sendAnalytics(EventTypes.PLAY_REACHED_100);
       }

diff --git a/test/src/kanalytics.spec.js b/test/src/kanalytics.spec.js
@@ -248,7 +248,7 @@ describe('KAnalyticsPlugin', function () {
 
     it('should send 100%', (done) => {
       player.addEventListener(player.Event.LOADED_METADATA, () => {
-        player.currentTime = 12.5;
+        player.getVideoElement().currentTime = 12.7;
       });
       player.addEventListener(player.Event.TIME_UPDATE, () => {
         const payload = sendSpy.lastCall.args[0];
@@ -274,7 +274,7 @@ describe('KAnalyticsPlugin', function () {
       };
       player.addEventListener(player.Event.LOADED_METADATA, () => {
         player.addEventListener(player.Event.TIME_UPDATE, onTimeUpdate);
-        player.currentTime = 12.5;
+        player.getVideoElement().currentTime = 12.7;
       });
       player.load();
     });
@@ -469,10 +469,10 @@ describe('KAnalyticsPlugin', function () {
               done();
             };
             player.addEventListener(player.Event.TIME_UPDATE, onTimeUpdate);
-            player.currentTime = 12.5;
+            player.getVideoElement().currentTime = 12.7;
           });
+          player.load();
         });
-        player.load();
       });
 
       player.addEventListener(player.Event.FIRST_PLAY, () => {