Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8321): block report if mandatory params are missing #32

Merged
merged 4 commits into from
Jun 17, 2018
Merged

feat(FEC-8321): block report if mandatory params are missing #32

merged 4 commits into from
Jun 17, 2018

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Jun 17, 2018

Description of the Changes

Don't send report if partner id or entry id are missing

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Jun 17, 2018
@OrenMe OrenMe requested a review from yairans June 17, 2018 09:57
@OrenMe OrenMe merged commit edaf560 into master Jun 17, 2018
@OrenMe OrenMe deleted the FEC-8321 branch June 17, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees

@OrenMe OrenMe

Labels
Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrenMe @yairans