Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10698): multi-request return entryId instead of sources, no playback #127

Merged
merged 2 commits into from
Nov 25, 2020
Merged

fix(FEC-10698): multi-request return entryId instead of sources, no playback #127

merged 2 commits into from
Nov 25, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Nov 25, 2020 •
edited
Loading

Description of the Changes

add data.sources existence protection

solves FEC-10698

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team November 25, 2020 13:48
@yairans yairans self-assigned this Nov 25, 2020
Yuvalke
Yuvalke previously approved these changes Nov 25, 2020
View reviewed changes
OrenMe
OrenMe previously approved these changes Nov 25, 2020
View reviewed changes
@yairans yairans dismissed stale reviews from OrenMe and Yuvalke via f13fea5 November 25, 2020 14:03
@yairans yairans merged commit 9e634f1 into master Nov 25, 2020
@yairans yairans deleted the FEC-10698 branch November 25, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuvalke Yuvalke Yuvalke left review comments

@OrenMe OrenMe OrenMe left review comments

Assignees

@yairans yairans

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yairans @OrenMe @Yuvalke