Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-12850): ECDN Fallback Option Upon Inaccessible API Gateway #201

Merged
merged 12 commits into from
Feb 2, 2023

Conversation

lianbenjamin
Copy link
Contributor

@lianbenjamin lianbenjamin commented Jan 30, 2023

Description of the Changes

add support for ECDN fallback upon inaccessible API gateway:

  • make a ping request of the configured cdn to check if accessible
  • the ping request should be executed only when there is accessControlActions configured with a regexAction
  • we should apply the regex replacement if a ping was made and it was successful, or regexAction exists and there is no timeout configured
  • add new configuration provider.env.replaceHostOnlyManifestUrls with default false, which indicates whether only playManifest urls should be applied with the regex; when configured to true- only play manifest urls should be replaced. if configured to false- in addition to manifest urls, apply the regex action to poster and captions urls

solves FEC-12850

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

src/k-provider/ovp/config.js Outdated Show resolved Hide resolved
src/k-provider/ovp/regex-action-handler.js Outdated Show resolved Hide resolved
src/k-provider/ovp/regex-action-handler.js Outdated Show resolved Hide resolved
src/k-provider/ovp/regex-action-handler.js Outdated Show resolved Hide resolved
src/k-provider/ovp/regex-action-handler.js Outdated Show resolved Hide resolved
src/k-provider/ovp/regex-action-handler.js Outdated Show resolved Hide resolved
src/k-provider/ovp/regex-action-handler.js Outdated Show resolved Hide resolved
src/k-provider/ovp/provider.js Outdated Show resolved Hide resolved
src/k-provider/ovp/regex-action-handler.js Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
src/k-provider/ovp/regex-action-handler.js Outdated Show resolved Hide resolved
src/k-provider/ovp/regex-action-handler.js Outdated Show resolved Hide resolved
src/k-provider/ovp/regex-action-handler.js Outdated Show resolved Hide resolved
@lianbenjamin lianbenjamin merged commit fbcf62b into master Feb 2, 2023
@lianbenjamin lianbenjamin deleted the FEC-12850 branch February 2, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants