chore: change ovp provider constructor & getConfig signature #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
suggested changes
Dec 3, 2017
src/k-provider/ovp/ovp-provider.js
Outdated
| this.partnerID = partnerID; | ||
| this.ks = ks; | ||
| constructor(options: {playerVersion: string, partnerID: number, ks: string, config: Object, loadUiConf: boolean, logLevel?: string}) { | ||
| this._playerVersion = options.playerVersion; |
There was a problem hiding this comment.
options could be null.
set to {} by default
src/k-provider/ovp/ovp-provider.js
Outdated
| * @param {string} entryId The entry ID | ||
| * @param {number} uiConfId The uiConf ID | ||
| * @param {string} entryId - The entry ID | ||
| * @param {number} uiConfId - The uiConf ID |
yairans
previously approved these changes
Dec 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Please add a detailed description of the change, weather it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.
CheckLists