Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prefix provider types #42

Merged
merged 1 commit into from
Jan 9, 2018
Merged

fix: prefix provider types #42

merged 1 commit into from
Jan 9, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jan 9, 2018 •
edited
Loading

Description of the Changes

Prefix provider types with Provider to avoid collision between types in kaltura player js.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Jan 9, 2018
@dan-ziv dan-ziv merged commit 80499d5 into master Jan 9, 2018
@dan-ziv dan-ziv deleted the prefix-provider-types branch January 9, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dan-ziv