Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-8096): some of OTT metadata is getting overriden #50

Merged
merged 4 commits into from
Apr 17, 2018
Merged

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Apr 3, 2018

Description of the Changes

changed the current structure of the metadata:

{
   0: {key: "someKey",
     value: "someValue"
    },
   1: {key: "someKey",
        value: "someValue"
    },
   2: {key: "someKey",
    value: "someValue"
    },
..
}

to

metas: {
  key1: value,
  key2: value,
...
},
tags: {
  key1: value,
  key2: value,
...
}
  • this also resolves the bug that some of the metas got overridden.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Apr 3, 2018
@dan-ziv dan-ziv merged commit 30a7553 into master Apr 17, 2018
@dan-ziv dan-ziv deleted the FEC-8096 branch April 17, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants