Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-8135): change the provider default service config to cdsnapisec.kaltura.com #51

Merged
merged 2 commits into from
May 5, 2018

Conversation

odedhutzler
Copy link
Contributor

Description of the Changes

change the OVP provider default service config to cdsnapisec.kaltura.com

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Apr 22, 2018
@@ -2,7 +2,7 @@
import {clone} from '../../util/clone'

const defaultConfig: Object = {
serviceUrl: "//www.kaltura.com/api_v3",
serviceUrl: "//cdnapisec.kaltura.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be https://cdnapisec.kaltura.com - need to check we don't add the protocol again in the code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked, we add the protocol to the cdnURL

@OrenMe OrenMe merged commit f05784b into master May 5, 2018
@OrenMe OrenMe deleted the FEC-8135 branch May 5, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants