fix(FEC-7180): fullscreen element change fix (#63)

kaltura · Oct 2, 2017 · aa4e090 · aa4e090
1 parent 97227fe
commit aa4e090
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/components/fullscreen/fullscreen.js b/src/components/fullscreen/fullscreen.js
@@ -33,7 +33,7 @@ class FullscreenControl extends BaseComponent {
    * @memberof FullscreenControl
    */
   constructor(obj: Object) {
-    super({name: 'Fullscreen', player: obj.player});
+    super({name: 'Fullscreen', player: obj.player, config: obj.config});
   }
 
   /**
@@ -102,7 +102,11 @@ class FullscreenControl extends BaseComponent {
       this.player.getView().getElementsByTagName('video')[0].webkitEnterFullscreen();
     }
     else {
-      this.requestFullscreen(this.player.getView().parentElement);
+      let elementToFullscreen = document.getElementById(this.config.targetId);
+
+      if (elementToFullscreen) {
+        this.requestFullscreen(elementToFullscreen);
+      }
     }
   }
 

diff --git a/src/ui-presets/ads.js b/src/ui-presets/ads.js
@@ -56,7 +56,7 @@ export default function adsUI(props: any): React$Element<any> {
               </div>
               <div className='right-controls'>
                 <VolumeControl player={props.player}/>
-                <FullscreenControl player={props.player}/>
+                <FullscreenControl player={props.player} config={props.config}/>
               </div>
             </BottomBar>
           </div>

diff --git a/src/ui-presets/playback.js b/src/ui-presets/playback.js
@@ -39,7 +39,7 @@ export default function playbackUI(props: any): React$Element<any> {
             <VolumeControl player={props.player} />
             <LanguageControl player={props.player} />
             <SettingsControl player={props.player} />
-            <FullscreenControl player={props.player} />
+            <FullscreenControl player={props.player} config={props.config} />
           </div>
         </BottomBar>
       </div>