Skip to content

Commit

Permalink
fix(FEC-12236,FEC-FEC-12237): VPAID ads part of the AD is cut (#677)
Browse files Browse the repository at this point in the history
center playback controls get z-index to let the user pause/play the player during the non-linear vpaid is displayed on small screen - see kaltura/playkit-js-ima#229
also, turn the spinner off when there is no AD_STARTED event but AD_PROGRESS (non-linera vpaid)

Solves FEC-12236, FEC-12237
  • Loading branch information
yairans authored May 18, 2022
1 parent 596c875 commit acb4af0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/components/loading/loading.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ class Loading extends Component {
this.props.updateLoadingSpinnerState(true);
});

eventManager.listen(player, player.Event.AD_PROGRESS, () => {
this.props.updateLoadingSpinnerState(false);
});

eventManager.listen(player, player.Event.AD_STARTED, () => {
if (this.props.adIsLinear) {
this.props.updateLoadingSpinnerState(false);
Expand Down
1 change: 1 addition & 0 deletions src/components/playback-controls/_playback-controls.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
-webkit-transform: translate(-50%, -50%);
-ms-transform: translate(-50%, -50%);
white-space: nowrap;
z-index: 1;
}

.bottom-bar .playback-controls {
Expand Down

0 comments on commit acb4af0

Please sign in to comment.