Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-11733): fix mouse cursor not appear on pre-playback issue #649

Merged
merged 5 commits into from
Jan 16, 2022

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Jan 16, 2022

Description of the Changes

issue: mouse cursor dose not appear on pre-playback
fix: add the pre-playback class
see https://kaltura.atlassian.net/browse/FEC-11733?focusedCommentId=1095772

solves: FEC-11733

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

.player.menu-active,
.player.overlay-active {
.player {
.pre-playback-play-overlay,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.pre-playback-play-overlay,
&.pre-playback-play-overlay,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are not sitting on the same element class attribute (like the rest)

@JonathanTGold JonathanTGold merged commit e491c28 into master Jan 16, 2022
@JonathanTGold JonathanTGold deleted the FEC-11733 branch January 16, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants