fix(FEC-12236,FEC-FEC-12237): VPAID ads part of the AD is cut #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
SivanA-Kaltura
approved these changes
May 18, 2022
yairans
added a commit
to kaltura/playkit-js-ima
that referenced
this pull request
May 18, 2022
for vpaid keep the playkit-ads element dimensions like the player dimensions since ima calculates the vpaid position based on it. this change causes the player overlay to be unclickable when non-linear vpaid is displayed. only the center playback controls get z-index to let the user pause/play the player during the non-linear vpaid is displayed on small screen - see kaltura/playkit-js-ui#677 also, add missing states for non-linear vpaid Solves FEC-12236, FEC-12237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
center playback controls get z-index to let the user pause/play the player during the non-linear vpaid is displayed on small screen - see kaltura/playkit-js-ima#229
also, turn the spinner off when there is no AD_STARTED event but AD_PROGRESS (non-linera vpaid)
Solves FEC-12236, FEC-12237
CheckLists