Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-10709, FEC-10712): player visibility - Auto-pause when player is out of view, Autoplay only when player is in view #24

Merged
merged 5 commits into from
Jan 14, 2021
Merged

feat(FEC-10709, FEC-10712): player visibility - Auto-pause when player is out of view, Autoplay only when player is in view #24

merged 5 commits into from
Jan 14, 2021

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Dec 24, 2020 •
edited
Loading

Description of the Changes

Migrated intersection observer logic from visibility plugin to KP

  • Removed threshold from plugin config and docs
  • PLAYER_VISIBILITY_CHANGED event is removed and not dispatched from plugin anymore
  • Floating is now observing using the new viewabilityManager
  • Plugin config - removed visibility level. plugin config is now called floating with the same floating config options

Solves FEC-10709, FEC-10712

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman
feat(FEC-10709, FEC-10712): player visibility - Auto-pause when playe…
5e3ec0c 
…r is out of view, Autoplay only when player is in view
@RoyBregman RoyBregman requested review from yairans, OrenMe, Yuvalke and dan-ziv and removed request for yairans and OrenMe December 24, 2020 12:55
Yuvalke
Yuvalke reviewed Dec 30, 2020
View reviewed changes
src/visibility.js Outdated Show resolved Hide resolved
Yuvalke
Yuvalke suggested changes Dec 30, 2020
View reviewed changes
src/visibility.js Outdated Show resolved Hide resolved
Yuvalke
Yuvalke suggested changes Jan 5, 2021
View reviewed changes
docs/configuration.md Show resolved Hide resolved
src/visibility.js Outdated Show resolved Hide resolved
src/visibility.js Show resolved Hide resolved
@RoyBregman RoyBregman merged commit 21765ac into master Jan 14, 2021
@RoyBregman RoyBregman deleted the FEC-10709-autoPause-new-design branch January 14, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuvalke Yuvalke Yuvalke approved these changes

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoyBregman @OrenMe @Yuvalke