New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10709): unObserve of viewability manager threw error #25

Merged

RoyBregman merged 1 commit into master from FEC-10709-destroy-fix

Jan 17, 2021

Contributor

RoyBregman commented Jan 17, 2021

was done on a null element. Should move before cleaning this._appTargetContainer

Solves FEC-10709

CheckLists

changes have been done against master branch, and PR does not conflict
new unit / functional tests have been added (whenever applicable)
test are passing in local environment
Travis tests are passing (or test results are not worse than on master branch :))
Docs have been updated


          fix(FEC-10709): unObserve of viewability manager was done on a null e…

491e615

…lement

RoyBregman requested review from Yuvalke, OrenMe, dan-ziv and yairans

January 17, 2021 09:37

Yuvalke approved these changes

View reviewed changes

RoyBregman merged commit 237801d into master

RoyBregman deleted the FEC-10709-destroy-fix branch

January 17, 2021 09:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet