Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-13662): apply new design for dismissing floating player #71

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

lianbenjamin
Copy link
Contributor

@lianbenjamin lianbenjamin commented Feb 13, 2024

Description of the Changes

  • enhancement
    • apply new design of dismissible area
    • add new functionality: when dismissing the floating player, scroll to the main player
    • since the new dismissible area (above the player) is adding 32px to the height of the entire floating container - calculating the total floating container height according to the height and dismissible configurations
image

Solves FEC-13662

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

src/visibility.js Show resolved Hide resolved
src/visibility.js Show resolved Hide resolved
src/components/dismissible/dismissible.js Show resolved Hide resolved
src/visibility.js Show resolved Hide resolved
SivanA-Kaltura
SivanA-Kaltura previously approved these changes Feb 14, 2024
@lianbenjamin lianbenjamin merged commit ba6bdb7 into master Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants