Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-10079): as a end user I would like to be able to drag to reposition floating player #9

Merged
merged 9 commits into from
Jul 26, 2020

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Jul 14, 2020

Description of the Changes

added dragging functionality - please notice I added also throttling mechanism using setTimeout

Solves FEC-10079

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman changed the title ffeat(FEC-10079): as a end user I would like to be able to drag to reposition floating player feat(FEC-10079): as a end user I would like to be able to drag to reposition floating player Jul 14, 2020
src/visibility.js Outdated Show resolved Hide resolved
src/visibility.js Outdated Show resolved Hide resolved
src/visibility.js Outdated Show resolved Hide resolved
src/visibility.js Show resolved Hide resolved
src/visibility.js Outdated Show resolved Hide resolved
src/visibility.js Show resolved Hide resolved
src/visibility.js Outdated Show resolved Hide resolved
src/visibility.js Outdated Show resolved Hide resolved
OrenMe
OrenMe previously approved these changes Jul 26, 2020
@OrenMe OrenMe requested a review from Yuvalke July 26, 2020 12:16
@RoyBregman RoyBregman merged commit 4d66553 into master Jul 26, 2020
@RoyBregman RoyBregman deleted the FEC-10079-draggable-floating branch July 26, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants