Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12952): Image and Youbora integration #108

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Feb 14, 2023

Description of the Changes

Add 'image' media type to Youbora Analytics

solves: FEC-12952

related prs:
kaltura/playkit-js-image-player#5
kaltura/playkit-js#702

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@JonathanTGold JonathanTGold merged commit a39b920 into master Feb 19, 2023
@JonathanTGold JonathanTGold deleted the FEC-12952 branch February 19, 2023 09:59
JonathanTGold added a commit to kaltura/playkit-js that referenced this pull request Feb 19, 2023
JonathanTGold added a commit to kaltura/playkit-js-image-player that referenced this pull request Feb 19, 2023
Youbora uses the player public API Like get src() getDrmInfo which is exposed by the engine interface which is not implemented yet by the engine

solves FEC-12952

related prs:
kaltura/playkit-js-youbora#108
kaltura/playkit-js#702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants