fix(base-plugin): getConfig api should return copy of his config (#123)

kaltura · Sep 26, 2017 · 26a74ea · 26a74ea
1 parent aafc22e
commit 26a74ea
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/plugin/base-plugin.js b/src/plugin/base-plugin.js
@@ -96,9 +96,9 @@ export default class BasePlugin implements IPlugin {
    */
   getConfig(attr?: string): any {
     if (attr) {
-      return this.config[attr];
+      return Utils.Object.copyDeep(this.config[attr]);
     }
-    return this.config;
+    return Utils.Object.copyDeep(this.config);
   }
 
   /**
@@ -108,7 +108,7 @@ export default class BasePlugin implements IPlugin {
    * @returns {void}
    */
   updateConfig(update: Object): void {
-    this.config = Utils.Object.mergeDeep(this.config, update);
+    Utils.Object.mergeDeep(this.config, update);
   }
 
   /**

diff --git a/test/src/plugin/base-plugin.spec.js b/test/src/plugin/base-plugin.spec.js
@@ -28,6 +28,13 @@ describe('BasePlugin', () => {
     basePlugin.getConfig().should.deep.equal(config);
   });
 
+  it('should return copy of the plugin config', () => {
+    basePlugin.getConfig().x = 100;
+    basePlugin.getConfig().y = 200;
+    basePlugin.getConfig().x.should.equals(1);
+    basePlugin.getConfig().y.should.equals(2);
+  });
+
   it('should return the config attribute value', () => {
     basePlugin.getConfig('x').should.deep.equal(1);
   });