Skip to content

Commit

Permalink
fix(FEC-12760): Blank Transcript Box In V7 Player (#682)
Browse files Browse the repository at this point in the history
  • Loading branch information
JonathanTGold committed Dec 21, 2022
1 parent 3184d98 commit a9400ab
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
13 changes: 7 additions & 6 deletions src/player.js
Original file line number Diff line number Diff line change
Expand Up @@ -2625,18 +2625,19 @@ export default class Player extends FakeEventTarget {
* @returns {string} - The track language to set by default.
*/
_getLanguage<T: TextTrack | AudioTrack>(tracks: Array<T>, configuredLanguage: string, defaultTrack: ?T): string {
let language = configuredLanguage;
if (language === AUTO) {
let autoSelectedLanguage: string = '';
const defaultStreamTrack: string = tracks.find(track => track.default)?.language || '';
if (configuredLanguage === AUTO) {
const localeTrack: ?T = tracks.find(track => Track.langComparer(Locale.language, track.language));
if (localeTrack) {
language = localeTrack.language;
autoSelectedLanguage = localeTrack.language;
} else if (defaultTrack && defaultTrack.language !== OFF) {
language = defaultTrack.language;
autoSelectedLanguage = defaultTrack.language;
} else if (tracks && tracks.length > 0) {
language = tracks[0].language;
autoSelectedLanguage = tracks[0].language;
}
}
return language;
return autoSelectedLanguage || configuredLanguage || defaultStreamTrack;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/track/text-track.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ const TextTrack: TextTrack = class TextTrack extends Track {
this._kind = settings.kind;
this._external = settings.external;
this._index = TextTrack._generateIndex();
this._default = this.active;
this._default = settings.default || false;
}
};

Expand Down

0 comments on commit a9400ab

Please sign in to comment.