feat: allow setting native hls and dash playback #106
Conversation
updated default method attribute values to be true for progressive playback support
src/player-config.json
Outdated
| @@ -7,14 +7,16 @@ | |||
| "preload": "none", | |||
| "autoplay": false, | |||
| "muted": false, | |||
| "options": { | |||
| "tweaks": { | |||
There was a problem hiding this comment.
@OrenMe if we're changing this key we should change also the reference in dash & hls adapters
| @@ -70,11 +77,15 @@ export default class NativeAdapter extends BaseMediaSourceAdapter { | |||
| * Checks if NativeAdapter can play a given mime type. | |||
| * @function canPlayType | |||
| * @param {string} mimeType - The mime type to check | |||
| * @param {boolean} preferNative - prefer native flag | |||
There was a problem hiding this comment.
you can annotate the default value true
@param {boolean} [preferNative=true] - prefer native flag
There was a problem hiding this comment.
Nice, didn't know this 👍
| @@ -65,15 +65,16 @@ export default class MediaSourceProvider { | |||
| /** | |||
| * Checks if the a media source adapter can play a given source. | |||
| * @param {Source} source - The source object to check. | |||
| * @param {boolean} preferNative - prefer native flag | |||
| @@ -95,7 +96,7 @@ export default class MediaSourceProvider { | |||
| static getMediaSourceAdapter(videoElement: HTMLVideoElement, source: Source, config: Object): ?IMediaSourceAdapter { | |||
| if (videoElement && source && config) { | |||
| if (!MediaSourceProvider._selectedAdapter) { | |||
| MediaSourceProvider.canPlaySource(source); | |||
| MediaSourceProvider.canPlaySource(source, false); | |||
There was a problem hiding this comment.
why do we even have this check here? we should be getting here after we already have a selectedAdapter anyway.
I'll change to true for consistency, but this seems unnecessary.
There was a problem hiding this comment.
This is api. You can asssume nothing how getting here.
Why true/false. You have the param from config
src/player-config.json
Outdated
| @@ -8,14 +8,16 @@ | |||
| "preload": "none", | |||
| "autoplay": false, | |||
| "muted": false, | |||
| "options": { | |||
| "tweaks": { | |||
There was a problem hiding this comment.
i think 'options' is more intuitive...
Description of the Changes
By default we use HLS and Dash adapters for playback of HLS and Dash streams.
This feature will allow setting the required adapter to be native or not, so we can use native HLS playback on Safari for example.
{ "playback": { "preferNative": { "hls": false, "dash": false } } }CheckLists