fix(FEC-7089): handle bitrate change in android browser #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
changed the title
OrenMe
suggested changes
Sep 13, 2017
| this._onTrackChanged(videoTrack); | ||
| }); | ||
| this._videoElement.currentTime = currentTime; | ||
| if (Env.browser.name === 'Android Browser') { |
There was a problem hiding this comment.
@yairans can we make it use the actual data fro video and not browser sniffing based?
Is it possible to check after LOADED_DATA if video.duration exist and only if not then register DURATION_CHANGE and call play?
Also, if I recall this is a known bug that on Android stock browser the loadeddata event is fired before even the loadedmetadata is fired, can we move this implemntation to use loadedmetadata instead? if so then we need to test it again on all environments/platforms.
OrenMe
approved these changes
Sep 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
On bitrate change for progressive download In Android browser (AKA native/stock browser) we have to seek to the current position only after some playback
CheckLists