feat: configure refactor #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
suggested changes
Sep 25, 2017
src/player.js
Outdated
| */ | ||
| _updatePlayerConfig(config: Object): void { | ||
| if (Utils.Object.isEmptyObject(this._config)) { | ||
| Utils.Object.mergeDeep(this._config, Player._defaultConfig, config); |
There was a problem hiding this comment.
Why no do this on init anyway?
added 2 commits
September 25, 2017 14:24
…it-js into configure-refactor
OrenMe
approved these changes
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Align configure api behavior:
Plugins:
Playback:
Playback can be configured at any time but this will affect only to until sources will be configured.
For example, If sources not yet configured and playback is configured, the playback configuration will take place when sources will received.
If sources already received and playback is configured again, the playback configuration will take place on the next sources configuration.
CheckLists