Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(base-plugin): getConfig api should return copy of his config #123

Merged
merged 3 commits into from
Sep 26, 2017
Merged

fix(base-plugin): getConfig api should return copy of his config #123

merged 3 commits into from
Sep 26, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Sep 25, 2017 •
edited
Loading

Description of the Changes

getConfig api should return copy of his config instead of reference.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Sep 25, 2017
@OrenMe
Copy link
Contributor

OrenMe commented Sep 25, 2017

@dan-ziv better add tests here before merge

OrenMe
OrenMe suggested changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tests

@dan-ziv
Copy link
Contributor Author

dan-ziv commented Sep 25, 2017

@OrenMe
Test added.

@dan-ziv dan-ziv merged commit 26a74ea into master Sep 26, 2017
@dan-ziv dan-ziv deleted the assign-copy-of-plugin-config branch September 26, 2017 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
Priority: Medium Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe