fix(FEC-7106): captions on IE & edge #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odedhutzler
requested review from
OrenMe,
dan-ziv and
yairans
and removed request for
OrenMe
OrenMe
suggested changes
Oct 25, 2017
src/player.js
Outdated
| */ | ||
| _removeCueTextPatch(): void { | ||
| const textCue = this._activeTextCues; | ||
| if (textCue.length > 0) { |
There was a problem hiding this comment.
_activeTextCues can be an array so need to iterate over all of it and throw out the out of bound cues and keep the ones in it
OrenMe
suggested changes
Oct 25, 2017
src/player.js
Outdated
| const cueEndTime = textCue._endTime; | ||
| const cueStartTime = textCue._startTime; | ||
| const currTime = this.currentTime; | ||
| if (currTime > cueEndTime || currTime < cueStartTime) { |
There was a problem hiding this comment.
you need to prepare the array you send to processCues before calling it as it is not aware of time, just display.
Calling it like this will cause only the last cue in the array to appear
OrenMe
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
patch to fix the captions issue on ie and edge, until this issue is resolved. when seeking to a place without captions, the previous captions (if there were any) are still shown. this patch removes them.
CheckLists