Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7345): only off option appears in text track menu (safari) #148

Merged
merged 2 commits into from
Oct 26, 2017
Merged

fix(FEC-7345): only off option appears in text track menu (safari) #148

merged 2 commits into from
Oct 26, 2017

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Oct 25, 2017 •
edited
Loading

Description of the Changes

do not parse track without language or label

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Oct 25, 2017
@yairans yairans changed the title fix(FEC-7345): change media - caption are shown with double off label (safari) fix(FEC-7345): only off option appears in text track menu (safari) Oct 25, 2017
@OrenMe OrenMe merged commit cff8e4e into master Oct 26, 2017
@OrenMe OrenMe deleted the FEC-7345 branch October 26, 2017 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe