fix(FEC-7266): reposition & resize captions when changing to/from full screen #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
suggested changes
Nov 1, 2017
OrenMe
suggested changes
Nov 1, 2017
src/player.js
Outdated
| } | ||
|
|
||
| // waiting the browser to render the screen | ||
| setTimeout(() => { |
There was a problem hiding this comment.
save timeout id and handle cases when events come in consecutive manner, e.g. debounce it.
Also, move timeout to const value.
There was a problem hiding this comment.
@OrenMe i didn't debounce it - just ignored previous timeouts (the last one will be the one that will be executed - i think that's the behavior we want)
OrenMe
suggested changes
Nov 1, 2017
src/player.js
Outdated
| this._repositionCuesTimeout = setTimeout(() => { | ||
| processCues(window, this._activeTextCues, this._textDisplayEl); | ||
| this._repositionCuesTimeout = false; | ||
| }, 1000); |
There was a problem hiding this comment.
Just move this to a const value, REPOSITION_CUES_TIMEOUT and we are good
OrenMe
suggested changes
Nov 1, 2017
OrenMe
approved these changes
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Changing the single full screen event to fire also an event when it ends (its a hack, we wait 500ms and fire the event because currently browsers does not support a "finished render full screen" event).
After the full screen event, we reposition and resize the captions.
CheckLists